Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating Julia to 1.9 #26

Merged
merged 3 commits into from
Nov 3, 2023
Merged

updating Julia to 1.9 #26

merged 3 commits into from
Nov 3, 2023

Conversation

farhadrclass
Copy link
Collaborator

Adding Julia 1.9.0 since we need to use Flux 1.3+ due to support for Float16 and also dynamic type change

@farhadrclass farhadrclass requested a review from tmigot November 3, 2023 00:11
@farhadrclass
Copy link
Collaborator Author

@tmigot here is the type change
CI still fails, I am checking why

@farhadrclass farhadrclass mentioned this pull request Nov 3, 2023
Merged
@farhadrclass
Copy link
Collaborator Author

@tmigot I think it fixed the CI problems

tmigot
tmigot approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @farhadrclass ! It looks good. Note that this is a breaking change, so next release will be a 0.2.0

@tmigot tmigot merged commit c91b63c into JuliaSmoothOptimizers:main Nov 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farhadrclass @tmigot