Add a function get_sparsity_pattern #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
force-pushed
the
auto_sparse
branch
from
ddbf563 to
6c5578d
Compare
tmigot
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Thanks for the PR @amontoison !
Here is a first batch of comments.
|
amontoison
force-pushed
the
auto_sparse
branch
from
04bd4d4 to
0cd1e10
Compare
amontoison
force-pushed
the
auto_sparse
branch
from
0cd1e10 to
339e048
Compare
amontoison
force-pushed
the
auto_sparse
branch
from
174fcf1 to
4991e76
Compare
tmigot
approved these changes
Nov 26, 2024
Co-authored-by: Tangi Migot <[email protected]>
|
Thanks for the review @tmigot 👍 |
amontoison
added a commit
that referenced
this pull request
Nov 27, 2024
* Add a function get_sparsity_pattern * Fix an error in sparsity_pattern.jl * Apply suggestions from code review Co-authored-by: Tangi Migot <[email protected]> * Fix a typo * Use multiple dispatch for get_sparsity_pattern * Fix sparse.md * Update src/sparsity_pattern.jl Co-authored-by: Tangi Migot <[email protected]> --------- Co-authored-by: Tangi Migot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #300
@frapac @sshin23 @jbcaillau @tmigot
I added a function,
get_sparsity_pattern, to easily extract the sparsity pattern of the Jacobian or the Hessian of the Lagrangian from anyADNLPModelorADNLSModel:https://jso.dev/ADNLPModels.jl/previews/PR307/sparse/#Extracting-sparsity-patterns
This could help detect specific patterns that can be exploited in the linear algebra computations.
Additionally, if a problem needs to be solved multiple times, we can skip the sparsity pattern detection step by directly injecting the previously extracted pattern.
Example: https://jso.dev/ADNLPModels.jl/dev/sparsity_pattern/