Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI allow failure on nightly #266

Closed
tmigot opened this issue Jul 6, 2024 · 5 comments
Closed

CI allow failure on nightly #266

tmigot opened this issue Jul 6, 2024 · 5 comments

Comments

@tmigot
Copy link
Member

tmigot commented Jul 6, 2024

Since this package constantly depend on cutting-edge AD packages, it will very often fail on the nightly anyway.
what do you think @amontoison ?

@amontoison
Copy link
Member

I propose to remove nightly builds.

@tmigot
Copy link
Member Author

tmigot commented Jul 6, 2024

It is still useful information, no?

@amontoison
Copy link
Member

Not with Zygote :)
I propose to remove it for now and add it again when we will rely on DI.jl.

@tmigot
Copy link
Member Author

tmigot commented Jul 7, 2024

I think it helps us having a grasp of what packages are breaking forever or what packages are making big changes (like Enzyme is sometimes breaking on the nightly but that's still under heavy dev'). Also some users may ask questions about using ADNLPModels under the nightly in which case I prefer to be aware of potential issues.

@amontoison
Copy link
Member

We now use buildkite for Enzyme and Zygote. We can keep builds on nightly for the package without optional dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants