Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 needs find_spec implemented in JuliaImporter #509

Closed
MilesCranmer opened this issue Nov 4, 2022 · 2 comments
Closed

Python 3.11 needs find_spec implemented in JuliaImporter #509

MilesCranmer opened this issue Nov 4, 2022 · 2 comments

Comments

@MilesCranmer
Copy link
Collaborator

With Python 3.11, JuliaImporter should implement find_spec, and JuliaModuleLoader should implement exec_module. Otherwise, the following warnings appear:

<frozen importlib._bootstrap>:1049: ImportWarning: JuliaImporter.find_spec() not found; falling back to find_module()
<frozen importlib._bootstrap>:673: ImportWarning: JuliaModuleLoader.exec_module() not found; falling back to load_module()

Shouldn't be too bad to implement though.

@MilesCranmer
Copy link
Collaborator Author

Yep, I think this is breaking PyJulia on 3.12 @mkitti. Seems like we need to implement find_spec (https://docs.python.org/3/library/importlib.html#importlib.abc.MetaPathFinder.find_spec) in JuliaImporter as well as exec_module in JuliaModuleLoader.

@MilesCranmer
Copy link
Collaborator Author

Fixed from #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant