Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] file is not passed to write_toml #118

Closed
schlichtanders opened this issue Oct 22, 2023 · 2 comments
Closed

[Bug] file is not passed to write_toml #118

schlichtanders opened this issue Oct 22, 2023 · 2 comments

Comments

@schlichtanders
Copy link

I just read through the code because I want to manipulate the toml without installing packages and saw that there is a tiny bug in how the file keyword argument is forwarded

https://github.com/JuliaPy/CondaPkg.jl/blob/main/src/deps.jl#L215-L224

function add(pkgs::AbstractVector; resolve=true, file=cur_deps_file(), kw...)
    toml = read_deps(; file)
    for pkg in pkgs
        add!(toml, pkg)
    end
-   write_deps(toml)
+   write_deps(toml; file)
    STATE.resolved = false
    resolve && CondaPkg.resolve(; kw...)
    return
end
@cjdoris
Copy link
Collaborator

cjdoris commented Oct 22, 2023

Thanks - I happened to be at my computer so fixed it immediately.

@schlichtanders
Copy link
Author

thank you too - that was really fast 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants