Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend compat and bump version #178

Open
itsdfish opened this issue May 15, 2023 · 4 comments
Open

Extend compat and bump version #178

itsdfish opened this issue May 15, 2023 · 4 comments

Comments

@itsdfish
Copy link

Hello,

I noticed there are a lot of pull requests for CompatHelper. Would it be possible to merge those pull requests and register a new version?

Thanks!

@devmotion
Copy link
Member

Hmm somehow I missed these PRs. Fortunately I think all of these compat updates are for docs/tutorials, so a new release is not needed? I guess they require manual intervention though since the corresponding Manifest.toml files have to be updated as well.

@itsdfish
Copy link
Author

itsdfish commented May 15, 2023

No problem. It's easy to miss.

Good question. I'm not sure how that works. Maybe when StatsBase is listed under extras, it won't block new versions of StatsBase.

@devmotion
Copy link
Member

I'm pretty sure the package supports the latest release of StatsBase without us merging any PRs - StatsBase is not a dependency of the package and no compat entries are specified for it: https://github.com/JuliaOptimalTransport/OptimalTransport.jl/blob/master/Project.toml

@matbesancon
Copy link

Adding OT at the current version drastically downgrades a lot of other packages (JuMP 1.23 --> 0.21 so more than two years ago), there are compat bounds here that seem to be limiting and pretty blocking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants