Add parallel_for API with keyword struct #188
Conversation
|
Test this please |
PhilipFackler
force-pushed
the
kw-struct
branch
2 times, most recently
from
30e3902 to
4c166a9
Compare
|
Test this please |
PhilipFackler
force-pushed
the
kw-struct
branch
from
4c166a9 to
f732585
Compare
|
Test this please |
PhilipFackler
force-pushed
the
kw-struct
branch
from
f732585 to
acef0e9
Compare
|
Test this please |
PhilipFackler
force-pushed
the
kw-struct
branch
from
acef0e9 to
ef6b464
Compare
|
Test this please |
|
|
||
| @kwdef mutable struct LaunchSpec{Backend} | ||
| stream = default_stream(Backend) | ||
| threads = 0 |
There was a problem hiding this comment.
Just curious why some are typed explicitly and some are not. FYI, this will default to Int64.
There was a problem hiding this comment.
the type of the stream is determined by the backend. Threads can be either an Integer or a tuple of 2 or 3 integers. same with blocks
| @@ -93,10 +128,10 @@ end | |||
| end | |||
|
|
|||
| @testset "reduce" begin | |||
| a = JACC.array([1 for i=1:10]) | |||
| a = JACC.array([1 for i in 1:10]) | |||
There was a problem hiding this comment.
Maybe for later, do a formatting only PR. It seems these are not functional changes.
There was a problem hiding this comment.
Good point, I did formatting as I was going with this one, so it applied to changes from prior to this PR.
| A = JACC.ones(Float32, N, N, N) | ||
| B = JACC.ones(Float32, N, N, N) | ||
| C = JACC.zeros(Float32, N, N, N) | ||
| JACC.parallel_for(JACC.launch_spec(; threads = (4, 4, 4)), |
There was a problem hiding this comment.
I guess this is required to be a first argument since we are using Varargs. Another overloaded version, for later, could be similar to CUDA.jl (since AMDGPU.jl now follows it):
JACC.@lauch_spec threads = (16, 16) blocks = (1,1) sync=false JACC.parallel_for(N, f, x...)
There was a problem hiding this comment.
I'll open an issue for this feature.
PhilipFackler
changed the title
|
@williamfgc ready. And we can just close the other PR. |
This addresses #179 and #180