Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed @maybe_threaded to work as intended with precompilation #158

Merged

Conversation

PhilipFackler
Copy link
Collaborator

Addresses #156.

With package precompilation, this macro was performing in "serial" mode regardless of JULIA_NUM_THREADS.

@PhilipFackler
Copy link
Collaborator Author

Test this please

@PhilipFackler PhilipFackler merged commit 56823cd into JuliaORNL:main Dec 13, 2024
4 of 5 checks passed
@miniskar
Copy link
Collaborator

miniskar commented Feb 9, 2025

The thread execution through IRIS is entering into hanging state with this modification. I observed that it is also going into hanging state with previous code also.
I am wondering the need of :static here? If I remove static, it works good in both cases.

@PhilipFackler
Copy link
Collaborator Author

@miniskar We probably don't need to specify a default scheduler. I can remove it next week. On the other hand, any idea why the static scheduler would cause a deadlock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants