Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMTk PR broke Makefile target used to retrieve all deps #57002

Closed
d-netto opened this issue Jan 9, 2025 · 2 comments · Fixed by #57038
Closed

MMTk PR broke Makefile target used to retrieve all deps #57002

d-netto opened this issue Jan 9, 2025 · 2 comments · Fixed by #57038
Labels
building Build system, or building Julia or its dependencies

Comments

@d-netto
Copy link
Member

d-netto commented Jan 9, 2025

We fetch the tarball with all dependencies' sources in our build.

The MMTk PR apparently broke that.

Running make -C deps getall on a x86_64 Linux machine gives me:

...
make: *** No rule to make target 'get-mmtk_julia', needed by 'getall'.  Stop.
make: Leaving directory '/home/ubuntu/julia-RAI/deps'
@d-netto d-netto added the building Build system, or building Julia or its dependencies label Jan 9, 2025
@d-netto
Copy link
Member Author

d-netto commented Jan 9, 2025

(Thanks @rbvermaa for investigating this).

@inkydragon
Copy link
Member

get-mmtk_julia: $(MMTK_JULIA_SRC_FILE)

$ make -j -C deps getall
make: Entering directory '/mnt/d/jl/julia/deps'
make: *** No rule to make target 'get-mmtk_julia', needed by 'getall'.  Stop.
make: Leaving directory '/mnt/d/jl/julia/deps'
$ make -C deps get-mmtk_julia
make: Entering directory '/mnt/d/jl/julia/deps'
make: *** No rule to make target 'get-mmtk_julia'.  Stop.
make: Leaving directory '/mnt/d/jl/julia/deps'
$ make -C deps print-MMTK_JULIA_SRC_FILE
make: Entering directory '/mnt/d/jl/julia/deps'
MMTK_JULIA_SRC_FILE=
make: Leaving directory '/mnt/d/jl/julia/deps'

So MMTK_JULIA_SRC_FILE is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants