Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrectly warning uses of warnings #3566

Closed
vtjnash opened this issue Aug 2, 2023 · 5 comments · Fixed by #3575
Closed

incorrectly warning uses of warnings #3566

vtjnash opened this issue Aug 2, 2023 · 5 comments · Fixed by #3575
Labels
precompile Pkg.precompile

Comments

@vtjnash
Copy link
Member

vtjnash commented Aug 2, 2023

The output text says "had warnings", but this text is not a warning, just informational advice, and it is harmful to users for Pkg to claim this is a warning:

julia> using Test1
Precompiling Test1
  Progress [>                                        ]  0/1
  ◑ Test1 Waiting for background task / IO / timer. Interrupt to inspect
 Interrupted: Exiting precompilation...

  1 dependency had warnings during precompilation:
┌ Test1 [ddca8587-cad1-46e2-86b4-b726afea1d60]
│  [pid 7156] waiting for IO to finish:
│   TYPE[FD/PID]       @UV_HANDLE_T->DATA
│   timer              @00000228c312eca0->00000228bf815db0

observed at JuliaPy/PyPlot.jl#572

@IanButterworth
Copy link
Member

I proposed “warning” to dissuade packages from using output during precompilation for anything other than warnings. It seems like something we don’t want to promote?

@IanButterworth IanButterworth added the precompile Pkg.precompile label Aug 2, 2023
@IanButterworth
Copy link
Member

@vtjnash let me know if you disagree, otherwise perhaps we can close this?

@vtjnash
Copy link
Member Author

vtjnash commented Aug 9, 2023

I think Pkg should avoid editorializing, although I agree it is not generally advisable, some messages just won't be warnings

@IanButterworth
Copy link
Member

Ok so warnings -> output ?

@vtjnash
Copy link
Member Author

vtjnash commented Aug 9, 2023

Yes, or something like "wrote text"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
precompile Pkg.precompile
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants