From 900bb953696bea4bc0c63c9936f1e84514722671 Mon Sep 17 00:00:00 2001
From: Tim Besard <tim.besard@gmail.com>
Date: Wed, 17 Aug 2022 15:34:53 +0200
Subject: [PATCH] Cache downloaded and extracted traces for the duration of the
 Julia session. (#89)

---
 Project.toml        |  2 +-
 src/BugReporting.jl | 26 +++++++++++++++++---------
 2 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/Project.toml b/Project.toml
index 79e9a59..b3b00be 100644
--- a/Project.toml
+++ b/Project.toml
@@ -2,7 +2,7 @@ name = "BugReporting"
 uuid = "bcf9a6e7-4020-453c-b88e-690564246bb8"
 authors = ["Keno Fischer <keno@juliacomputing.com>",
            "Tim Besard <tim.besard@gmail.com>"]
-version = "0.2.6"
+version = "0.2.7"
 
 [deps]
 AWS = "fbe9abb3-538b-5e4e-ba9e-bc94f4f92ebc"
diff --git a/src/BugReporting.jl b/src/BugReporting.jl
index 1e69218..d419030 100644
--- a/src/BugReporting.jl
+++ b/src/BugReporting.jl
@@ -43,6 +43,7 @@ end
 # Values that are initialized in `__init__()`
 default_rr_record_flags = ``
 julia_checkout = ""
+trace_cache = ""
 
 struct InvalidPerfEventParanoidError <: Exception
     value
@@ -234,10 +235,12 @@ function decompress_rr_trace(trace_file, out_dir)
 end
 
 function decompress_rr_trace(trace_file)
-    # Extract into temporary directory (we'll clean-up when the process exists)
-    dir = mktempdir()
-    decompress_rr_trace(trace_file, dir)
-    return dir
+    # extract, cached for the duration of this session
+    trace_dir = joinpath(trace_cache, basename(trace_file))
+    if !isdir(trace_dir)
+        decompress_rr_trace(trace_file, trace_dir)
+    end
+    return trace_dir
 end
 
 function download_rr_trace(trace_url)
@@ -256,12 +259,16 @@ function download_rr_trace(trace_url)
     end
     progress = isinteractive() ? update_progress : nothing
 
-    mktempdir() do dl_dir
-        # Download into temporary directory (we'll clean-up straight away)
-        local_path = joinpath(dl_dir, "trace.tar.zst")
-        Downloads.download(trace_url, local_path; progress=progress)
-        decompress_rr_trace(local_path)
+    # download and extract, cached for the duration of this session
+    trace_dir = joinpath(trace_cache, basename(trace_url))
+    if !isdir(trace_dir)
+        mktempdir() do dl_dir
+            local_path = joinpath(dl_dir, "trace.tar.zst")
+            Downloads.download(trace_url, local_path; progress=progress)
+            decompress_rr_trace(local_path, trace_dir)
+        end
     end
+    return trace_dir
 end
 
 function get_sourcecode(commit)
@@ -582,6 +589,7 @@ function __init__()
     end
 
     global julia_checkout = @get_scratch!("julia")
+    global trace_cache = mktempdir()
 end