Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigatomic_end throws error with VSCode Debugger #371

Closed
mrufsvold opened this issue Jul 7, 2022 · 3 comments
Closed

sigatomic_end throws error with VSCode Debugger #371

mrufsvold opened this issue Jul 7, 2022 · 3 comments

Comments

@mrufsvold
Copy link
Contributor

mrufsvold commented Jul 7, 2022

VideoIO.get_time_duration() runs normally when I use it from the Julia REPL. However, when using the Julia Debugger in VSCode, it throws the following exception

sigatomic_end called in non-sigatomic region

Stacktrace:
 [1] close(avin::VideoIO.AVInput{String})
   @ VideoIO C:\Users\mrufsvold\.julia\packages\VideoIO\V24Bg\src\avio.jl:968
 [2] get_time_duration(file::String)
   @ VideoIO C:\Users\mrufsvold\.julia\packages\VideoIO\V24Bg\src\info.jl:45

It appears that PyCall had the same problem, and they were able to resolve it by replacing sigatomic_(end|begin) with disable_sigint. My understanding from reading their conversation is that sigatomic_(end|begin) is an internal function for Julia and disable_sigint is its the public API sibling.

I can put in a PR if the maintainers aren't opposed to the change for some reason!

@IanButterworth
Copy link
Member

Sounds reasonable. PR welcome!

@mrufsvold
Copy link
Contributor Author

Excellent! Upon further inspection, looks like there are lots of functions (load, get_number_frames, etc) that use the same pattern. I'll try changing them and submit the PR soon!

@IanButterworth
Copy link
Member

Closed by #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants