Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a parametrization function for Wedge #1162

Merged
merged 9 commits into from
Jan 20, 2025

Conversation

mikeingold
Copy link
Contributor

@mikeingold mikeingold commented Jan 20, 2025

Changes

  • Implements a parametrization function for Wedge, wedge(u, v, w):
    • Use vertices to generate two quadrangle faces with consistent point order.
    • Use (u, v) to locate corresponding points on each quadrangle.
    • Use (w) to locate a point on the segment between those points.
  • Adds two @tests on this parametrization function:
    • check whether function produced an expected result.
    • check whether out-of-bounds parametric coordinates throw an error.

@mikeingold mikeingold added the enhancement New feature or request label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (3f12c6a) to head (c1e8b69).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
+ Coverage   87.79%   87.81%   +0.01%     
==========================================
  Files         193      193              
  Lines        6057     6065       +8     
==========================================
+ Hits         5318     5326       +8     
  Misses        739      739              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm
Copy link
Member

juliohm commented Jan 20, 2025

Did some minor simplifications assuming that the Quadrangle and Segment parametrizations will take care of the type number type T. Let's see if tests pass.

@juliohm juliohm merged commit 58d5b28 into JuliaGeometry:master Jan 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants