"p_lim_plast=1" does not go to output.dat when set up a visco-plastic model

[wenrongcao]

This issue concerns the default value of p_lim_plast = 1, which is a needed setup to run a visco-plastic model (model without elasticity).

p_lim_plast = 1 is set by default in the LaMEM.lj's source code: SolutionParams.jl.

When I ran the model.SolutionParams cell in Julia (see attached screenshot), p_lim_plast = 1 is printed in black color, which means I did not change its default value.

However, the output.dat missed p_lim_plast keyword. I must explicitly type p_lim_plast = 1 in the model.SolutionParams cell to make the keyword listed in the output.dat.

After contacting Boris, he suggested a pull request should be made to set p_lim_plast = 0 in the source code: SolutionParams.jl.

I open this issue for bookkeeping purposes, and I will fix it shortly.

[boriskaus]

Can you give a minimum working example that reproduces this as well?

[wenrongcao]

@boriskaus, thanks for asking me to double-check. Now I find p_lim_plast = 1 keyword in every output.dat even I do not explicitly assign its value in Julia. This means the codes work as expected.

I probably mistaken the keyword with other similar ones (e.g., p_litho_plast =1) in my previous email communications with you. I will still keep an eye on this keyword in recent jobs. I will close this issue if everything is working as expected.

[boriskaus]

most important is that it is listed when a LaMEM simulation starts; every parameter that is set is listed, so here you can double-check that all is set as expected.