Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark CI failures due to too many requests #516

Open
christiangnrd opened this issue Jan 6, 2025 · 2 comments
Open

Benchmark CI failures due to too many requests #516

christiangnrd opened this issue Jan 6, 2025 · 2 comments

Comments

@christiangnrd
Copy link
Contributor

Example

Seems like buildkite rate limits are org-wide. Is there anything we can do in this repo to minimize the chances of running into this limit?

I tried debugging until I realized benchmark picks up the main branch workflow, but EnricoMI/download-buildkite-action has hardcoded timings for retry attempts so I don't know if we could do much.

@christiangnrd christiangnrd changed the title Benchmark CI failing due to too many requests Benchmark CI failures due to too many requests Jan 6, 2025
@maleadt
Copy link
Member

maleadt commented Jan 7, 2025

I tried debugging until I realized benchmark picks up the main branch workflow

That's because of the workflow triggering on the pull request target:

pull_request_target:
branches:
- main

EnricoMI/download-buildkite-action has hardcoded timings for retry attempts so I don't know if we could do much.

Should be easy enough to make that configurable, either in a fork of the plugin or by creating a PR?

@christiangnrd
Copy link
Contributor Author

EnricoMi/download-buildkite-artifact-action#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants