-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer no trailing slash #2473
Comments
That seems kinda subjective. Aesthetically, I think I have a slight preference for including the slash. Not a strong preference, so I don't really care if we want to change it. But is it worth the effort? I feel like Although I am a little confused. I always thought that whether or not there is a final slash is completely handled by the browser, and the two URLs with or without the slash are equivalent as far as the HTTP protocol is concerned. Regarding LuxDL/DocumenterVitepress.jl#64 (comment)
I might be wrong, but isn't So, I think the handling of paths in Documenter with |
Also, isn't the |
Based on the explanation in LuxDL/DocumenterVitepress.jl#64 (comment), it seems that the trailing slash is correct, and dropping the slash would be incorrect (it would only work with specific server configurations). Should we close this? |
Maybe closing this was a little premature. It could be an "extra pretty" modification of the existing |
Note: this redirect is done by GitHub, not Documenter. So there is nothing we can do (to the best of my knowledge). Documenter sites are assumed to be hosted as static sites. File-based servers generally (universally? In any case, most importantly, GitHub Pages) 301 redirect So I don't think this is actionable (unless we want to go back to |
My recommendation is to put files in You can see this in action at IMO Documenter.jl's current approach is a reasonable amount more sensible and understandable for folks looking at the gh-pages branch, and possibly (though unconfirmed) more portable to different static site servers while the approach I use for https://chairmarks.lilithhafner.com is a tiny bit more sensible and understandable for website visitors. |
That GitHub Pages serves |
That seems like a reasonable choice. Ultimately its a matter of preference and it's your call. |
Right now, https://documenter.juliadocs.org/stable/man/guide#Installation redirects to https://documenter.juliadocs.org/stable/man/guide/#Installation, inserting a trailing slash (before the fragment). Personally, I would prefer the reverse redirect and canonical link. Unless the link is to a directory or container of some sort (as opposed to an ordinary web page) I strongly prefer no terminal slash. I also prefer no terminal slash for landing pages that lie somewhere between terminal pages and directories (e.g. https://documenter.juliadocs.org/stable).
See also: LuxDL/DocumenterVitepress.jl#64
The text was updated successfully, but these errors were encountered: