[REVIEW]: ExponentialFamilyManifolds.jl: Representing exponential families as Riemannian manifolds

[editorialbot]

Submitting author: @Nimrais (Mykola Lukashchuk)
Repository: https://github.com/ReactiveBayes/ExponentialFamilyManifolds.jl
Branch with paper.md (empty if default branch): paper
Version: v1.5.0
Editor: @lucaferranti
Reviewers: @kellertuer, @olivierverdier
Archive: Pending

Status

Status badge code:

HTML: <a href="https://proceedings.juliacon.org/papers/771aa3bfc1b353957a97f6819ad541f5"><img src="https://proceedings.juliacon.org/papers/771aa3bfc1b353957a97f6819ad541f5/status.svg"></a>
Markdown: [![status](https://proceedings.juliacon.org/papers/771aa3bfc1b353957a97f6819ad541f5/status.svg)](https://proceedings.juliacon.org/papers/771aa3bfc1b353957a97f6819ad541f5)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@kellertuer & @olivierverdier, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucaferranti know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @olivierverdier

📝 Checklist for @kellertuer

[editorialbot]

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper source files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1137/141000671 is OK
- 10.1145/3618296 is OK
- 10.21105/joss.03866 is OK
- 10.1162/089976698300017746 is OK
- 10.1080/01621459.2017.1285773 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: ExponentialFamily.jl
- No DOI given, and none found for title: Forward-Mode Automatic Differentiation in Julia

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.98  T=0.05 s (1684.6 files/s, 169655.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              8            239            187           2391
Julia                           55            451            291           1640
TOML                             5            335              2           1602
Markdown                         2             80              0            215
YAML                             5              0              3            161
Ruby                             1              8              4             45
-------------------------------------------------------------------------------
SUM:                            76           1113            487           6054
-------------------------------------------------------------------------------

Commit count by author:

    39	Mykola Lukashchuk
    28	Bagaev Dmitry
    15	İsmail Şenöz
     3	albertpod
     2	bvdmitri
     1	CompatHelper Julia

[editorialbot]

Paper file info:

📄 Wordcount for paper.tex is 1045

🔴 Failed to discover a Statement of need section in paper

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[olivierverdier]

Review checklist for @olivierverdier

Conflict of interest

• I confirm that I have read the JuliaCon conflict of interest policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JCon for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JuliaCon code of conduct.

General checks

• Repository: Is the source code for this software available at the https://github.com/ReactiveBayes/ExponentialFamilyManifolds.jl?
• License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@Nimrais) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

• Authors: Does the paper.pdf file include a list of authors with their affiliations?
• A statement of need: Does the paper clearly explain the problem it addresses, its importance to the broader community, the intended audience, and how it connects to existing work in the field?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Content

• Context: is the scientific context motivating the work correctly presented?
• Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
• Results: are the results presented and compared to approaches with similar goals?

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[lucaferranti]

Hi @Nimrais 👋 and thank you for submitting to JuliaCon proceedings.

I will be the editor handling this submission and this issue is for the review.

Huge thanks to @kellertuer and @olivierverdier for volunteering as reviewers 🙏 . To get started you can generate your reviewer checklist by commenting

@editorialbot generate my checklist

on this issue.

As you go through the checklist points, you can leave your comments for the author to address either in this issue or as issues on the software repository. If you do the latter, please make sure to link to this issue too.

If you have any questions at any point, do not hesitate to ping me and ask.

[kellertuer]

Review checklist for @kellertuer

Conflict of interest

• I confirm that I have read the JuliaCon conflict of interest policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JCon for the purpose of this review.

Code of Conduct

• I confirm that I read and will adhere to the JuliaCon code of conduct.

General checks

• Repository: Is the source code for this software available at the https://github.com/ReactiveBayes/ExponentialFamilyManifolds.jl?
• License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
• Contribution and authorship: Has the submitting author (@Nimrais) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• Installation: Does installation proceed as outlined in the documentation?
• Functionality: Have the functional claims of the software been confirmed?
• Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Paper format

• Authors: Does the paper.pdf file include a list of authors with their affiliations?
• A statement of need: Does the paper clearly explain the problem it addresses, its importance to the broader community, the intended audience, and how it connects to existing work in the field?
• References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Content

• Context: is the scientific context motivating the work correctly presented?
• Methodology: is the approach taken in the work justified, presented with enough details and reference to reproduce it?
• Results: are the results presented and compared to approaches with similar goals?

[olivierverdier]

@editorialbot generate pdf

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈