-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid piracy #1248
Comments
Strictly speaking, this isn't piracy, as the narrower method is defined in Base. It would be good to remove this, though, if possible |
It would be great if we actually had non-ambiguous documentation about what is and what isn't type piracy so that we can be sure what is and what is not wrong, ref. JuliaLang/julia#51669 . Currently there seems to be no consensus nor clear communication from core Julia devs regarding this "wider union" case. |
The generic methods with mixed axis types should not be necessary after JuliaLang/julia#56902 if |
StaticArrays does some piracy, at least in
similar()
:StaticArrays.jl/src/abstractarray.jl
Lines 141 to 146 in 07c1245
Here,
and it fits eg
Tuple{}
,Tuple{Int}
,Tuple{Int, Int}
.It's generally a good thing to avoid piracy in foundational packages. Maybe, also related to ambiguities like JuliaArrays/StructArrays.jl#279?..
The text was updated successfully, but these errors were encountered: