Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example using Meshes.jl #98

Merged
merged 12 commits into from
Oct 26, 2024
Merged

Add example using Meshes.jl #98

merged 12 commits into from
Oct 26, 2024

Conversation

JoshuaLampert
Copy link
Owner

  • Add an example, which uses NodeSets generated by Meshes.jl and add test for it. For this we need Meshes.jl v0.52.1.
  • Improve Meshes.jl extension, such that no internals are used.
  • Add small section about visualization with Makie via Meshes.jl to docs.

@JoshuaLampert
Copy link
Owner Author

I also bumped the Meshes.jl in Project.toml instead of only in test/Project.toml for two reasons: 1. Downgrade fails otherwise, 2. I think every example should be runnable with just adding KernelInterpolation.jl, which means KernelInterpolation.jl should enforce a compatible Meshes.jl version also for all examples.

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (6b0e46c) to head (b6d9281).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          43       44    +1     
  Lines        1171     1174    +3     
=======================================
+ Hits         1155     1158    +3     
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert JoshuaLampert merged commit e323b00 into main Oct 26, 2024
17 checks passed
@JoshuaLampert JoshuaLampert deleted the example-meshes branch October 26, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant