Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avian3d::dynamics::rigid_body::forces is only exported via prelude #626

Closed
SetOfAllSets opened this issue Jan 13, 2025 · 2 comments · Fixed by #630
Closed

avian3d::dynamics::rigid_body::forces is only exported via prelude #626

SetOfAllSets opened this issue Jan 13, 2025 · 2 comments · Fixed by #630
Labels
A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on

Comments

@SetOfAllSets
Copy link
Contributor

SetOfAllSets commented Jan 13, 2025 •
edited
Loading

see: bevyengine/bevy#17337 (comment)
@SetOfAllSets
Copy link
Contributor Author

SetOfAllSets commented Jan 14, 2025 •
edited
Loading

Perhaps the error is that avian3d::dynamics::rigid_body::forces isn't exported? Upon reviewing the code I only found that avian3d::dynamics::rigid_body::forces specifically had this issue

@SetOfAllSets SetOfAllSets changed the title Manually set reflect path avian3d::dynamics::rigid_body::forces is only exported via prelude Jan 14, 2025
@SetOfAllSets
Copy link
Contributor Author

Everything defined in avian3d::dynamics::rigid_body::forces is not only common, but required for rigidbodys (for now) so not having it be a public module and rexporting it via the prelude is weird

@SetOfAllSets SetOfAllSets mentioned this issue Jan 14, 2025
Merged
Jondolf pushed a commit that referenced this issue Jan 24, 2025
@SetOfAllSets
Make avian3d::dynamics::rigid_body::forces public (#630)
0156404 
# Objective

Fixes #626

## Solution

Make avian3d::dynamics::rigid_body::forces public

---

## Changelog

avian3d::dynamics::rigid_body::forces is now public
@Jondolf Jondolf added the A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Dynamics Relates to rigid body dynamics: motion, mass, constraint solving, joints, CCD, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make avian3d::dynamics::rigid_body::forces public SetOfAllSets/avian
2 participants
@Jondolf @SetOfAllSets