Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken error message in StaticxGenerator._handle_lib_symlinks() #278

Open
JonathonReinhart opened this issue Jan 15, 2024 · 0 comments
Open

Broken error message in StaticxGenerator._handle_lib_symlinks() #278

JonathonReinhart opened this issue Jan 15, 2024 · 0 comments
Labels
bug

Comments

@JonathonReinhart
Copy link
Owner

staticx/staticx/api.py

Lines 239 to 240 in 2a8214e

raise InternalError(
f"libname {libname} absent from _added_libs but symlink {arcname} present")

libname is not defined in _handle_lib_symlinks().

This seems to have been broken during refactoring in a6b7763.
JonathonReinhart added a commit that referenced this issue Jan 16, 2024
@JonathonReinhart
staticx: Add type info to staticx.api WIP
9101a4b 
One slightly annoying issue is that I like to set attributes to None in
close() after they've been closed. But this requires marking their types
as Optional, which requires checking that they are not None where they
are used. A well-polished API would check and raise a "closed"
exception. For now, we just assert.

This also fixes #278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonathonReinhart