Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deterministic ordering of snapshot selectors #178

Closed
Jon-Becker opened this issue Nov 17, 2023 · 2 comments · Fixed by #184
Closed

deterministic ordering of snapshot selectors #178

Jon-Becker opened this issue Nov 17, 2023 · 2 comments · Fixed by #184
Assignees
@iankressin
Labels
A-core Area: core C-snapshot Command: snapshot D-easy Difficulty: easy P-low Priority: low T-feature Type: feature

Comments

@Jon-Becker
Copy link
Owner

Component

Heimdall (Core)

Describe the feature you would like

Motivation

The snapshot module has a non-deterministic ordering of selectors when output:

image

This would be a small qol change that would make using the module easier.

Solution

Sort the output by selector ascending (0x00000000 first to 0xffffffff last)
@Jon-Becker Jon-Becker added A-core Area: core C-snapshot Command: snapshot D-easy Difficulty: easy P-low Priority: low T-feature Type: feature good first issue Good for new contributors labels Nov 17, 2023
@iankressin iankressin mentioned this issue Nov 19, 2023
Merged
@iankressin
Copy link
Contributor

I saw the issues you posted on twitter and took the liberty to fix this one on #184

@Jon-Becker
Copy link
Owner Author

Awesome awesome! I'll review this tomorrow morning!

@Jon-Becker Jon-Becker removed the good first issue Good for new contributors label Nov 19, 2023
@Jon-Becker Jon-Becker linked a pull request Nov 19, 2023 that will close this issue
feat(snapshot): sort selectors ascending #184
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iankressin iankressin

Labels
A-core Area: core C-snapshot Command: snapshot D-easy Difficulty: easy P-low Priority: low T-feature Type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(snapshot): sort selectors ascending iankressin/heimdall-rs
2 participants
@iankressin @Jon-Becker