Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary #5

Open
sangjunp4rk opened this issue Jul 7, 2017 · 1 comment
Open

Summary #5

sangjunp4rk opened this issue Jul 7, 2017 · 1 comment

Comments

@sangjunp4rk
Copy link

Summary Grade: Satisfactory

Good job with your code! I really like the use of indentation and whitespace in your html and css code! Makes your code very easy to read! Your clean is very concise. Great start to the Ready program!

I included a few notes in both the html can css files for you to think more critically about. First, make sure to keep your html and css code separate. Right now you are combining them and rewriting a lot of code. Second, try to save your images locally instead of adding a link. Saving images adds to the stability of your website because your website is not reliant on the link to be valid all the time. Also, make sure to use the html & sign instead of just &, which is &. This is just a convention. Finally, your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79-100 characters per line.

@JoieTsun
Copy link
Owner

Thank you for the tips!! For clarification's sake, any spaces or returns I add into the code won't make a difference in the end result as long as the correct HTML tags are attached? Also, what did you mean by the html & sign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants