Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameters configurable #857

Closed
alytarik opened this issue Oct 24, 2023 · 1 comment · Fixed by #866
Closed

Make parameters configurable #857

alytarik opened this issue Oct 24, 2023 · 1 comment · Fixed by #866
Assignees
Labels
💡Enhancements Something can be improved

Comments

@alytarik
Copy link
Contributor

alytarik commented Oct 24, 2023

Explore and convert hardcoded thresholds/parameters to config based ones.

Current Findings:

  • CrowS-Pairs
    • diff_treshold
    • filter_treshold
  • Wino-Bias
    • diff_treshold
@alytarik alytarik added 💡Enhancements Something can be improved v2.1.0 Issue or request to be done in v2.1.0 release labels Oct 24, 2023
@alytarik alytarik self-assigned this Oct 24, 2023
@ArshaanNazir
Copy link
Collaborator

Kindly look for other cases as well. Like Wino-bias also has hardcoded ones ( because we came up with those after manual review from annotators as well). However if user wants to change them according to his choice, it should be possible. Can we do that for the sentence transformers as well, where in user can choose and use those only.

@alytarik alytarik linked a pull request Oct 30, 2023 that will close this issue
5 tasks
@alytarik alytarik closed this as completed Nov 7, 2023
@chakravarthik27 chakravarthik27 removed the v2.1.0 Issue or request to be done in v2.1.0 release label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡Enhancements Something can be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants