Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rider plugins cannot be built with useInstaller=true #1852

Open
ForNeVeR opened this issue Dec 22, 2024 · 0 comments
Open

Rider plugins cannot be built with useInstaller=true #1852

ForNeVeR opened this issue Dec 22, 2024 · 0 comments
Labels

Comments

@ForNeVeR
Copy link
Contributor

ForNeVeR commented Dec 22, 2024

What happened?

Consider this build.gradle.kts:

dependencies {
    intellijPlatform {
        rider("2024.3.2")
        jetbrainsRuntime()
        instrumentationTools()

        bundledModule("intellij.rider")
        bundledPlugins("com.jetbrains.xaml.previewer")

        testFramework(TestFrameworkType.Bundled)
    }

    implementation(libs.bson4Jackson)

    testImplementation(libs.openTest4J)
}

This will fail, because rider("2024.3.2") leads to implicit useInstaller = true, and Rider (so far) is never supported when building a plugin using installer. See internal issue RIDER-119106 for details on that; there are plans to allow to use the installers but so far it's not possible.

This causes confusion among users (especially since you migrate from 243 EAP to 243 and build gets broken — it's not easy to figure out that it's the implicit property that gets switched between these).

I suggest us to automatically disable useInstaller for Rider, unless it's been explicitly passed as useInstaller = true (while I never seen cases when it's used and works, theoretically it's possible for some very light usages, e.g. when a plugin only depends a conditional XML file or something like that).

Gradle IntelliJ Plugin version

2.2.0

Gradle version

8.12

Operating System

None

Link to build, i.e. failing GitHub Action job

No response

@ForNeVeR ForNeVeR added the bug label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant