Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a JUnit 5 Extension instead of a JUnit 4 Rule #2371

Closed
hakanai opened this issue Oct 7, 2022 · 2 comments
Closed

Provide a JUnit 5 Extension instead of a JUnit 4 Rule #2371

hakanai opened this issue Oct 7, 2022 · 2 comments

Comments

@hakanai
Copy link

hakanai commented Oct 7, 2022

Since the test API is considered experimental anyway, and given that JUnit 4 has been outdated for some time now, it would be nice if the current TestRule were replaced by a Extension.

I already took a shot at writing such a thing in my own code, but the structure of the current TestRule makes it impossible to reuse - it's implemented by wrapping around the test execution, which is the one kind of extension which JUnit 5 doesn't have support for.

I also attempted to pull the code out of the current test rule to write a new extension, but it's relying on a lot of internal classes, so I think I'd have to clone the entire module to get anything working.
@hakanai hakanai mentioned this issue Oct 7, 2022
Closed
@mahozad
Copy link
Contributor

mahozad commented Oct 10, 2022

Related: android/android-test#224

igordmn added a commit that referenced this issue Aug 17, 2023
@igordmn
Stabilize UI Test library for Desktop
533bae8 
For iOS/Web it will be stabilized with stabilizing these targets themselves. Also, we should expose uiTest for them, not uiTestJUnit4

JUnit5 support will be provided in the future in [this issue](#2371)

## API Changes

- Testing framework is stabilized for Desktop
- `compose.uiTestJUnit4` is renamed to `compose.desktop.uiTestJUnit4`
This was referenced Aug 17, 2023
Closed
Merged
igordmn added a commit that referenced this issue Aug 17, 2023
@igordmn
Stabilize UI Test library for Desktop (#3518)
6df509f 
For iOS/Web it will be stabilized with stabilizing these targets themselves. Also, we should expose uiTest for them, not uiTestJUnit4

JUnit5 support will be provided in the future in [this issue](#2371)

## API Changes

- Testing framework is stabilized for Desktop
- `compose.uiTestJUnit4` is renamed to `compose.desktop.uiTestJUnit4`
igordmn added a commit that referenced this issue Aug 17, 2023
@igordmn
Stabilize UI Test library for Desktop (#3518)
5eda586 
For iOS/Web it will be stabilized with stabilizing these targets themselves. Also, we should expose uiTest for them, not uiTestJUnit4

JUnit5 support will be provided in the future in [this issue](#2371)

## API Changes

- Testing framework is stabilized for Desktop
- `compose.uiTestJUnit4` is renamed to `compose.desktop.uiTestJUnit4`
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hakanai @mahozad @okushnikov