Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion false positives for snakemake.io, etc. #61

Open
iromeo opened this issue Jun 23, 2019 · 1 comment
Open

Completion false positives for snakemake.io, etc. #61

iromeo opened this issue Jun 23, 2019 · 1 comment
Labels
bug Something isn't working codeInsight Code completion, resolve
Milestone

Comments

@iromeo
Copy link
Contributor

iromeo commented Jun 23, 2019

Current completion implementation adds all top-level methods from snakemake.io to autocompletion, although snakemake imports only some of methods, e.g.

See

# ~/anaconda/envs/snakemake/lib/python3.6/site-packages/snakemake/workflow.py
from snakemake.io import protected, temp, temporary, ancient, directory, expand, dynamic, glob_wildcards, flag, not_iterable, touch, unpack, local, pipe, repeat, report

E.g. contains_wildcard_constraints method shouldn't be visible in autocompletion. We need smarter impl. Related to #1

image

@iromeo iromeo added bug Something isn't working codeInsight Code completion, resolve labels Jun 23, 2019
@iromeo iromeo assigned iromeo and unassigned iromeo Jun 23, 2019
@iromeo
Copy link
Contributor Author

iromeo commented Aug 31, 2019

We need to emulate from snakemake.workflow import * to resolve this

@iromeo iromeo self-assigned this Aug 31, 2019
@iromeo iromeo added this to the Backlog milestone Jul 3, 2020
@iromeo iromeo removed their assignment Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codeInsight Code completion, resolve
Projects
None yet
Development

No branches or pull requests

1 participant