-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting the order of multiple globbed files #292
Comments
@JessicaTegner I have added a fix for this in my PR. Can I be assigned to this. Let me know if I have to edit my code, thanks. |
Co-authored-by: Jessica Tegner <[email protected]>
Hello @JessicaTegner , I saw that this request was merge here: #292 Upgrading from My suggestion is that the sorting should be done on user side. The change should be revert then. cc @psychemedia |
IIRC, my original issye was inconsistency between default pandoc and pypandoc behaviours. |
I think the multiple I must be left to pandoc instead of doing it in this library Pandoc accepts this command: When we use pypandoc as this: instead of listing individually files before passing them to Pandoc as done here: https://github.com/JessicaTegner/pypandoc/blob/master/pypandoc/__init__.py#L159-L168 This will avoid inconsistency between pypandoc and pandoc and reduce the processing needed in this package. WDYT @JessicaTegner |
@fsoedjede that seems okay on the surface, but I'm not sure if that would mean that we would run in to some errors with automatics detection of the file type (since I'm pretty sure we do that at some point) |
Also @fsoedjede I just tried your command and I get the following output
|
Hi @JessicaTegner! I'm trying to track down the same Admittedly, I'm kinda doing something weird, but maybe these details help (?)... I'm running something like It'd be nice if searching pandoc source code repo and/or issues for this error produced anything... ;-) |
PR #248 supports the ability to pass multiple files, but I notice that if I pass a glob pattern (eg
*.html
) to combine multiple files into a single PDF:If a glob pattern is passed, eg to capture files
01.md
,02.md
etc, it would be really useful if the sort order were respected.The text was updated successfully, but these errors were encountered: