Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix core Dart types with 'Dart' when they conflict with built-in .NET types #36

Open
JeroMiya opened this issue Jul 18, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JeroMiya
Copy link
Owner

Lots of the dart code uses Dart types like Dictionary<,>. There are custom subclasses of .net collections with Dart methods added in Globals.cs but in many cases these cause type ambiguity errors in the transpiler output. For example:

https://github.com/JeroMiya/xamarin.flutter/blob/master/FlutterSDK/src/Foundation/Diagnostics.cs#L809

Prefix these conflicting types with Dart, e.g. DartDictionary so that they don't result in ambiguity errors.

@JeroMiya JeroMiya added bug Something isn't working good first issue Good for newcomers labels Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant