From db394e6037727306d9bfae59963ad8ed2e24e49e Mon Sep 17 00:00:00 2001 From: erikj Date: Tue, 5 Dec 2017 23:11:27 +0100 Subject: [PATCH] 8191439: Race in building jdk.rmic.interim Reviewed-by: mchung, tbell, ihse --- make/CompileInterimLangtools.gmk | 4 ++-- make/CompileInterimRmic.gmk | 4 ++-- make/autoconf/spec.gmk.in | 8 +++++--- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/make/CompileInterimLangtools.gmk b/make/CompileInterimLangtools.gmk index afdb14a936..b8ff3af48a 100644 --- a/make/CompileInterimLangtools.gmk +++ b/make/CompileInterimLangtools.gmk @@ -69,8 +69,8 @@ define SetupInterimModule Standard.java, \ EXTRA_FILES := $(BUILDTOOLS_OUTPUTDIR)/gensrc/$1.interim/module-info.java, \ COPY := .gif .png .xml .css .js javax.tools.JavaCompilerTool, \ - BIN := $(BUILDTOOLS_OUTPUTDIR)/interim_modules/$1.interim, \ - ADD_JAVAC_FLAGS := --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_modules \ + BIN := $(BUILDTOOLS_OUTPUTDIR)/interim_langtools_modules/$1.interim, \ + ADD_JAVAC_FLAGS := --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_langtools_modules \ $$(INTERIM_LANGTOOLS_ADD_EXPORTS) \ -Xlint:-module, \ )) diff --git a/make/CompileInterimRmic.gmk b/make/CompileInterimRmic.gmk index acc02c34bc..6127e930c0 100644 --- a/make/CompileInterimRmic.gmk +++ b/make/CompileInterimRmic.gmk @@ -65,10 +65,10 @@ $(eval $(call SetupJavaCompilation, BUILD_jdk.rmic.interim, \ EXCLUDE_FILES := $(TOPDIR)/src/jdk.rmic/share/classes/module-info.java, \ EXTRA_FILES := $(BUILDTOOLS_OUTPUTDIR)/gensrc/jdk.rmic.interim/module-info.java, \ INCLUDES := $(RMIC_PKGS), \ - BIN := $(BUILDTOOLS_OUTPUTDIR)/interim_modules/jdk.rmic.interim, \ + BIN := $(BUILDTOOLS_OUTPUTDIR)/interim_rmic_modules/jdk.rmic.interim, \ COPY := .properties, \ ADD_JAVAC_FLAGS := \ - --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_modules \ + --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_rmic_modules \ --add-modules java.corba \ --add-exports java.corba/com.sun.corba.se.impl.util=jdk.rmic.interim \ $(INTERIM_RMIC_ADD_EXPORTS), \ diff --git a/make/autoconf/spec.gmk.in b/make/autoconf/spec.gmk.in index b8449f7804..84ff78339a 100644 --- a/make/autoconf/spec.gmk.in +++ b/make/autoconf/spec.gmk.in @@ -577,7 +577,7 @@ INTERIM_LANGTOOLS_MODULES_COMMA := $(strip $(subst $(SPACE),$(COMMA),$(strip \ INTERIM_LANGTOOLS_ARGS := \ --limit-modules java.base,jdk.zipfs,$(INTERIM_LANGTOOLS_MODULES_COMMA) \ --add-modules $(INTERIM_LANGTOOLS_MODULES_COMMA) \ - --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_modules \ + --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_langtools_modules \ $(INTERIM_LANGTOOLS_ADD_EXPORTS) \ # JAVAC_MAIN_CLASS = -m jdk.compiler.interim/com.sun.tools.javac.Main @@ -588,8 +588,10 @@ INTERIM_RMIC_MODULES := $(addsuffix .interim, $(INTERIM_RMIC_BASE_MODULES)) INTERIM_RMIC_ADD_EXPORTS := \ --add-exports java.corba/com.sun.corba.se.impl.util=jdk.rmic.interim \ # -INTERIM_RMIC_ARGS := --limit-modules java.base,jdk.compiler,jdk.javadoc,java.corba \ - --module-path $(BUILDTOOLS_OUTPUTDIR)/interim_modules \ +# Use = to delay expansion of PathList since it's not available in this file. +INTERIM_RMIC_ARGS = --limit-modules java.base,jdk.compiler,jdk.javadoc,java.corba \ + --module-path $(call PathList, $(BUILDTOOLS_OUTPUTDIR)/interim_rmic_modules \ + $(BUILDTOOLS_OUTPUTDIR)/interim_langtools_modules) \ $(INTERIM_RMIC_ADD_EXPORTS) \ #