Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparKV PR(s) to upstream #10651

Open
3 of 11 tasks
djellemah opened this issue Jan 16, 2025 · 0 comments
Open
3 of 11 tasks

SparKV PR(s) to upstream #10651

djellemah opened this issue Jan 16, 2025 · 0 comments
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling
Milestone

Comments

@djellemah
Copy link
Contributor

Upstream recent SparKV modifications to https://github.com/uzyn/sparkv


Description

Development target issue

No specific issue.

PR #10593 added generics and wasm-compatible time calculations.

Those can be upstreamed.

Implementation Details

The following might need to be separate PRs to upstream:

  • Generics are unlikely to be controversial, and require

  • Size calculation to provide a meaningful per-item size currently uses a function. This might need to be modified to use a trait so that sensible per-type size calculations can be performed.

  • WASM-compatible time calculations might require a further type parameter to the top-level struct.

  • use of BTreeMap instead of HashMap to provide stable ordering can probably be implemented as a type parameter.


Prepare

  • Read contribution guidelines
  • Read license information

Identified code changes

  • task 1
  • task 2
  • task 3

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code

Document the changes

  • task for updating user guides if needed
  • task for updating installation and configuration guides if needed
  • task for updating developer documentation if needed
  • task for updating technical documentation if needed
@djellemah djellemah added the comp-jans-cedarling Touching folder /jans-cedarling label Jan 16, 2025
@djellemah djellemah self-assigned this Jan 16, 2025
@moabu moabu added this to the next-release milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling
Projects
None yet
Development

No branches or pull requests

2 participants