Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only traverse top-level definitions that actually have bangs #15

Closed
JakobBruenker opened this issue Dec 24, 2023 · 1 comment
Closed

Comments

@JakobBruenker
Copy link
Owner

Since we know where the GHC throws errors about bang patterns in expression contexts, it should be possible to only traverse/modify the ASTs of the definitions those expressions are in.

Doing this should improve performance.

We could also do it in a more fine-grained way, e.g. if the bang pattern happens in a where block, there's no reason to modify anything outside of that particular definition in the where block.

@JakobBruenker
Copy link
Owner Author

This is probably not worth it for the time being - the performance impact in general isn't that big and #14 provides more benefit for less effort

@JakobBruenker JakobBruenker closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant