EPUB import #12457
EPUB import #12457
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
|
I would appreciate it if anyone can give me places where I can download ePUB books and include them in JabRef tests. I only took books in public domain from Project Gutenberg, but they appear to be strictly in one format. However, on their websites I found other ePUBs that have different contents of ZIP-archive (This is the reason why I search for any |
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
| * Adapted from <a href="https://stackoverflow.com/a/79077999/10037342">...</a>. | ||
| */ | ||
| public static Path remapZipPath(Path zipPath) throws IOException { | ||
| final File tempFile = File.createTempFile("PREFIX" + UUID.randomUUID(), "SUFFIX"); |
There was a problem hiding this comment.
Use nio Files.createTempFile https://jsparrow.github.io/rules/create-temp-files-using-java-nio.html#description
| addField(StandardField.URL, identifier); | ||
| } | ||
|
|
||
| addField(StandardField.AUTHOR, Optional.of(String.join(" and ", authors))); |
There was a problem hiding this comment.
What does it do? Parsing authors? Why do I need it there?
Authors are specified separately in <dc:author>. Should be...
UPDATE: Ah, crap, I remember seeing sometimes it's not. Should investigate a bit.
There was a problem hiding this comment.
I remember that there is a fetcher which has a similar schema, take a look at that one
| return IntStream | ||
| .range(0, nodes.getLength()) | ||
| .mapToObj(i -> nodes.item(i).getTextContent()) | ||
| .filter(s -> !(s == null || s.isBlank())) // Just in case. |
There was a problem hiding this comment.
We have StringUtil isNullOrBlank somewhere
| * @return {@link Optional#empty()} if the {@param string} is empty, otherwise wrap it in {@link Optional}. | ||
| */ | ||
| public static Optional<String> optionalOfEmpty(String string) { | ||
| return Optional.ofNullable(string).filter(s -> !s.isEmpty()); |
There was a problem hiding this comment.
there is a similar existing method already isNotBlank which takes already an optional
|
|
||
| private static Stream<String> invalidFileNames() throws IOException { | ||
| // Clashes with ZIP-based formats are inevitable. | ||
| Predicate<String> fileName = name -> !name.startsWith("EpubImporterTest") && !name.startsWith("CitaviXmlImporterTest"); |
There was a problem hiding this comment.
why do you. need to exclude citavixml? isn't the EpubImporterTest already unique enough as prefix
There was a problem hiding this comment.
Nuh huh
This is invalidFileNames. This includes all files that are not EpubImporterTest....
However, those Citavi files, specifically .cvt6back (or something like that) are ZIP-files (headers match), thus I need to exclude them.
Yes, a better way to do this is to match the extension, but if I remember correctly, name does not contain extension, so I had to use prefix.
I'll look into it again if I could match better.
+ Comment needs to be refined
EPUB has some bits of metadata, so why not import it
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)- [ ] Screenshots added in PR description (for UI changes)