Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Visitor IP checking #4

Open
ghost opened this issue Aug 4, 2014 · 2 comments
Open

Visitor IP checking #4

ghost opened this issue Aug 4, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 4, 2014

As now, Visitor take into consideration visitors who has the same IP if they don't have the same useragent, E.G :

BUG

Visitor shouldn't create a new entry into the database if they has the same IP, even if it's not the same useragent.

@JN-Jones
Copy link
Owner

JN-Jones commented Aug 4, 2014

I'm not sure here. If I'd only check the IP all users behind a dhcp server would be handled as one. Let me check something

@JN-Jones
Copy link
Owner

JN-Jones commented Aug 4, 2014

I think it's ok atm: a session id is generated and saved for every user (including guests) so when you're always using the same browser only one entry is added. But when you're using a different browser (or another PC behind a dhcp) a new entry is added as the sid isn't set

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant