Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt valid-style.yml for JCSDA spack #290

Merged

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jun 30, 2023

Description

This PR adds style checks to the CI using a trimmed-down version of the main Spack workflow.

Issue(s) addressed

Fixes #281

Dependencies

none

Impact

none

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Since this file is from mainline spack, we'll have to manually sync any updates to their style checks in the future ...

@climbfuji climbfuji merged commit 4e474f8 into JCSDA:jcsda_emc_spack_stack Jul 6, 2023
@climbfuji climbfuji deleted the add_style_checks branch July 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add style checks to CI
2 participants