Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download URL for crtm v3 not working #245

Closed
climbfuji opened this issue Mar 17, 2023 · 0 comments · Fixed by #246
Closed

Download URL for crtm v3 not working #245

climbfuji opened this issue Mar 17, 2023 · 0 comments · Fixed by #246
Assignees
@climbfuji
Labels
bug Something is not working

Comments

@climbfuji
Copy link
Collaborator

When I added the URL for URL for the new CRTM v3 release candidate, I made two mistakes:

  • url_for_version only applies for hashes, not for git commits
  • v3 doesn't get evaluated as .not. < Version(3.0.0)

I'll have a PR that fixes this in a minute. This needs to go in asap before creating the release branches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@climbfuji climbfuji

Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix for "Download URL for crtm v3 not working" climbfuji/spack
1 participant
@climbfuji