Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this repo needs to be synced with main spack repo #209

Closed
3 tasks done
edwardhartnett opened this issue Dec 22, 2022 · 6 comments · Fixed by #254 or JCSDA/spack-stack#545
Closed
3 tasks done

this repo needs to be synced with main spack repo #209

edwardhartnett opened this issue Dec 22, 2022 · 6 comments · Fixed by #254 or JCSDA/spack-stack#545
Assignees
Labels
bug Something is not working

Comments

@edwardhartnett
Copy link
Collaborator

Steps to reproduce

It does us no good to have our own version of spack. We need to expose it to the community and also let the community help us.

So we need to merge our changes to the main spack repo. We need users to be able to build from the main spack repo, and have it work the same as for us.

It's not clear that the NCO will accept updates from our fork of the main spack repo. They will accept updates on the main spack repo. That means the NCEPLIBS team will not be updating the fork of spack, we will instead be updating the main spack repo when we do a release.

THis spack fork, if it continues to be used, must fetch those changes from the main spack repo. Yet we do not seem to be updating this fork from the main spack repo - we need to.

Error message

v

Information on your system

f

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have searched the issues of this repo and believe this is not a duplicate
  • I have run the failing commands in debug mode and reported the output
@edwardhartnett edwardhartnett added the bug Something is not working label Dec 22, 2022
@climbfuji
Copy link
Collaborator

This is a duplicate of #28.

It's not clear that the NCO will accept updates from our fork of the main spack repo. They will accept updates on the main spack repo. That means the NCEPLIBS team will not be updating the fork of spack, we will instead be updating the main spack repo when we do a release.

Let me ask the reverse question. Is spack going to accept the changes that NCO requires us to put into a number of packages so that they can be installed on FISMA HIGH systems?

@climbfuji
Copy link
Collaborator

I do agree with you of course that we need to keep the differences minimal. To get things started, I am first going to update our fork from the authoritative repo, so that we can send our changes back cleanly. PR to come

@edwardhartnett
Copy link
Collaborator Author

Excellent. Once that is done I will see if there are any differences in the NCEPLIBS library package files that can be pushed up to the main repo.

@climbfuji
Copy link
Collaborator

@edwardhartnett We just merged the update from the authoritative repo as of Dec 22. Since both repos are marching ahead all the time, you need to compare the following hashes to get a good idea of what is different:
noaa-emc fork, jcsda_emc_spack_stack branch: 3a15213
spack repo, develop branch: 38c1639

@climbfuji
Copy link
Collaborator

We are making progress on this.

@climbfuji
Copy link
Collaborator

CLosing this, since it is a duplicate of #28

@climbfuji climbfuji closed this as not planned Won't fix, can't repro, duplicate, stale Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
2 participants