Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail because of module hash check #151

Closed
3 tasks done
kgerheiser opened this issue Aug 5, 2022 · 2 comments
Closed
3 tasks done

Unit tests fail because of module hash check #151

kgerheiser opened this issue Aug 5, 2022 · 2 comments
Assignees
Labels
bug Something is not working

Comments

@kgerheiser
Copy link

kgerheiser commented Aug 5, 2022

Steps to reproduce

See https://github.com/NOAA-EMC/spack/runs/7694783875?check_suite_focus=true

>       assert service_part in path_parts
410
E       AssertionError: assert 'mpich/3.0.4-d7mxhy7' in ['mpich/3.0.4', 'Core']

A hash is expected in the module name, but there is only the version.

I think this is related to some change that was made somewhere inside of Spack about LMod modules always having a hash.

Error message

No response

Information on your system

n/a

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have searched the issues of this repo and believe this is not a duplicate
  • I have run the failing commands in debug mode and reported the output
@kgerheiser kgerheiser added the bug Something is not working label Aug 5, 2022
@climbfuji
Copy link
Collaborator

I think this is more a bug on the unit testing side (in our fork) now that we built in the capability to shorten the module name hashes or omit them entirely.

@climbfuji climbfuji self-assigned this Sep 16, 2022
@climbfuji
Copy link
Collaborator

Closed via ##188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants