gsi-ncdiag to authoritative spack repository

[aerorahul]

gsi-ncdiag is required in the various GSI uses
gsi-ncdiag is in the NOAA-EMC fork of spack, but not in the authoritative spack repo.
https://github.com/NOAA-EMC/spack/blob/jcsda_emc_spack_stack/var/spack/repos/jcsda-emc/packages/gsi-ncdiag/package.py

Can a PR be opened into the authoritative spack repo for gsi-ncdiag so NOAA/NCEP/NCO can fetch and install from the authoritative repo instead of the fork. This significantly speeds up processing the installation request.

Is your feature request related to a problem? Please describe.
No problem. Just improving process for getting software installed on operational platforms.

Describe the solution you'd like
gsi-ncdiag is in the NOAA-EMC fork of spack, but not in the authoritative spack repo.

Additional context
This request of installation of gsi-ncdiag is being held up on WCOSS2
I also opened a parallel issue in the NOAA-EMC fork of spack at JCSDA/spack#239

[ulmononian]

@aerorahul i'll get a PR in for this

[ulmononian]

@aerorahul PR in here: spack/spack#35999

[ulmononian]

@aerorahul PR in here: spack/spack#35999

@aerorahul aforementioned spack PR was merged.

[ulmononian]

can this be closed @aerorahul @climbfuji?

[climbfuji]

Yes for me.

[aerorahul]

Thank you @ulmononian for opening this PR and following up.