Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden tests for the validation benchmarks #6828

Open
effectfully opened this issue Feb 10, 2025 · 0 comments
Open

Add golden tests for the validation benchmarks #6828

effectfully opened this issue Feb 10, 2025 · 0 comments

Comments

@effectfully
Copy link
Contributor

Current the validation benchmarks don't see to have any golden tests ensuring that what scripts evaluate to doesn't change. Unlike e.g. nofib or bitwise benchmarks (and lists ones have some property tests). We should fix that, otherwise an apparent optimization might as well turn out to be a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant