Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet: runTestnet: don't tie it with H.Integration #6122

Open
smelc opened this issue Feb 19, 2025 · 1 comment
Open

cardano-testnet: runTestnet: don't tie it with H.Integration #6122

smelc opened this issue Feb 19, 2025 · 1 comment

Comments

@smelc
Copy link
Contributor

smelc commented Feb 19, 2025

runTestnet takes a Conf -> H.Integration a callback, as visible here:

runTestnet :: CardanoTestnetOptions -> (Conf -> H.Integration a) -> IO ()

This is a bit meh and we can probably improve that: in the case where the user provides a configuration file, we would like not be tied to the hedgehog-extras/hedgehog APIs like Integration and Property. But this is something we would better do in the future, not in this PR, because it's not required for reaching a first release of cardano-testnet IMHO. And also, it will be some work, because our existing "backend", e.g. cardanoTestnet here is in the Integration monad. So it's not an easy change.

Originally posted by @smelc in #6103 (comment)

This issue keeps track of making possible, in the case where the user is calling the cardano-tesnet executable (as made possible by #6103), to not be tied to a testing monad (the likes of H.Integration and Property). This will be quite a change, because this monad actually spreads to a number of places.

@carbolymer
Copy link
Contributor

A prerequisite to: #5848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants