Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Annotator DecCBOR instances #4846

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jan 21, 2025

Description

Write DecCBOR instances for types that have DecCBOR Annotator instances, by leveraging the Maybe ByteString in versioned Decoder.

Depends on era-less Memobytes PR: #4844
Closes: #4818

binary 
	PV1.Data                     EXISTS
core 
	BootstrapWitness             DONE (with new raw type and decodeMemoized)
	WitVKey kr                   DONE (with new raw type and decodeMemoized)
	MemoBytes t era              EXISTS
	PlutusData era               DONE (with fromPlainDecoder)
	Data era                     DONE (deriving newtype)
	PlutusBinary                 EXISTS
	Block h era                  DONE (with new raw type and decodeMemoized)
tpraos 
	BHeader c                    DONE
shelley 
	ShelleyTxRaw era             DONE
	ShelleyTx era                DONE
	ShelleyTxSeq era 
	MultiSig era                 DONE
	MultiSigRaw era              DONE
	ShelleyTxAuxDataRaw era      EXISTS
	ShelleyTxAuxData era         DONE (deriving newtype)
	ShelleyTxBodyRaw era         EXISTS
	ShelleyTxBody era            DONE (deriving newtype) 
	ShelleyTxWitsRaw era         DONE
	ShelleyTxWits era            DONE
	LaxBlock h era               DONE 
allegra 
	AllegraTxBodyRaw () era      EXISTS
	AllegraTxBody era            DONE (deriving newtype) 
	TimelockRaw era              DONE
	Timelock era                 DONE (with decodeMemoized)
	AllegraTxAuxDataRaw era      DONE
	AllegraTxAuxData era         DONE (deriving newtype)
mary 
	MaryTxBodyRaw era            EXISTS
	MaryTxBody era               DONE (deriving newtype) 
alonzo 
	AlonzoTxBody era             DONE (deriving newtype) 
	AlonzoTxBodyRaw era          EXISTS
	AlonzoTxSeq era            
	AlonzoScript era             DONE
	AlonzoTx era                 DONE  
	AlonzoTxAuxDataRaw era       DONE 
	AlonzoTxAuxData era          DONE 
	TxDatsRaw era                DONE
	TxDats era                   DONE 
	RedeemersRaw era             DONE
	Redeemers era                DONE
	AlonzoTxWitsRaw era          DONE
	AlonzoTxWits era             DONE
	TranslationInstance era      DONE
babbage
	BabbageTxBody era            DONE 
	BabbageTxBodyRaw era         EXISTS
conway
	ConwayTxBodyRaw era          EXISTS 
	ConwayTxBody era             DONE

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/nonannotator-deccbor-instances branch 11 times, most recently from 39174ef to 0c97dae Compare January 29, 2025 11:18
@teodanciu teodanciu force-pushed the td/nonannotator-deccbor-instances branch from 5bd2b7d to 03a5f42 Compare January 29, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new DecCBOR instances that will replace Annotator instances
1 participant