Add hash checks for drep registration-certificate and drep update-certificate
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
added
enhancement
palas
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
kevinhammond and
disassembler
as code owners
carbolymer
reviewed
Sep 30, 2024
carbolymer
reviewed
Sep 30, 2024
carbolymer
reviewed
Sep 30, 2024
cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
smelc
reviewed
Sep 30, 2024
cardano-cli/src/Cardano/CLI/EraBased/Commands/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
Jimbo4350
requested changes
Sep 30, 2024
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
cardano-cli/test/cardano-cli-golden/Test/Golden/Governance/DRep.hs
Outdated
Show resolved
Hide resolved
palas
force-pushed
the
add-hash-validation3
branch
2 times, most recently
from
7aa748c to
eebcbd8
Compare
Jimbo4350
reviewed
Oct 1, 2024
palas
force-pushed
the
add-hash-validation3
branch
2 times, most recently
from
f631392 to
8a86ea8
Compare
palas
force-pushed
the
add-hash-validation3
branch
2 times, most recently
from
cb78b02 to
e1ec7c8
Compare
palas
force-pushed
the
add-hash-validation3
branch
from
e1ec7c8 to
4d9cf93
Compare
Jimbo4350
approved these changes
Oct 4, 2024
...est/cardano-cli-golden/files/golden/help/latest_governance_drep_registration-certificate.cli
Outdated
Show resolved
Hide resolved
palas
force-pushed
the
add-hash-validation3
branch
from
4d9cf93 to
2cb236c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This is another step forward on addressing #882.
Previous related PR: #915
This only adds checks to commands inside
governance drep. There are several other places where to add the check, but better to go step by step.How to trust this PR
I have adapted test for all commands but one, to validate the new functionality, and that gives me a lot of confidence. I would try to check that the code style is good, I didn't introduce any bugs, the parameter structure and names make sense, and the help is comprehensive and comprehensible.
Checklist