Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watchdog for property tests in cardano-cli-test #1072

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 25, 2025

Changelog

- description: |
    Add watchdog for property tests
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
   - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Our property tests sometimes hang in Hydra. This PR adds 20 seconds watchdog to each property test to ensure they're killed and fail early and do not block Hydra.

Each of our property test finishes under 5 seconds so that should be enough to catch the test hang.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Feb 25, 2025
@carbolymer carbolymer force-pushed the mgalazyn/test/investigate-hydra-hangups branch from 7a4ac57 to 66d88da Compare February 25, 2025 08:45
@carbolymer carbolymer force-pushed the mgalazyn/test/investigate-hydra-hangups branch from 66d88da to 5c14ebf Compare February 25, 2025 09:01
@carbolymer carbolymer changed the title Add watchdog for property tests Add watchdog for property tests in cardano-cli-test Feb 25, 2025
@carbolymer carbolymer marked this pull request as ready for review February 25, 2025 09:22
@carbolymer carbolymer added this pull request to the merge queue Feb 27, 2025
Merged via the queue into master with commit a1d8c95 Feb 27, 2025
27 of 29 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/investigate-hydra-hangups branch February 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants