Add stake address registration and delegation certificate and stake pool delegation certificate to compatible commands #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
carbolymer
force-pushed
the
mgalazyn/feature/add-more-compatible-commands
branch
from
2e3e4d7 to
d1bc917
Compare
carbolymer
force-pushed
the
mgalazyn/feature/add-more-compatible-commands
branch
2 times, most recently
from
52daacd to
48414a5
Compare
carbolymer
force-pushed
the
mgalazyn/feature/add-more-compatible-commands
branch
8 times, most recently
from
859a1fe to
107da6c
Compare
carbolymer
changed the title
carbolymer
requested review from
Jimbo4350,
newhoggy,
smelc,
palas,
kevinhammond and
disassembler
as code owners
Jimbo4350
requested changes
Feb 26, 2025
…ompatible commands run in CIO
…mmands. Make them run in CIO instead of ExceptT
carbolymer
force-pushed
the
mgalazyn/feature/add-more-compatible-commands
branch
from
107da6c to
9480b1c
Compare
Jimbo4350
approved these changes
Feb 27, 2025
| throwCliError = throwIO | ||
| -- | Wrapper function which allows throwing of types of instance `Error`, attaching call stack | ||
| -- from the call site | ||
| throwCliError :: (HasCallStack, Show e, Typeable e, Error e, MonadIO m) => e -> m a |
There was a problem hiding this comment.
IIRC this will return a callstack to this module. It's slightly ugly IMO but I wouldn't block the PR on this.
|
|
||
| fromEitherCli :: (HasCallStack, MonadIO m, Show e, Typeable e, Error e) => Either e a -> m a | ||
| fromEitherCli = withFrozenCallStack $ \case | ||
| Left e -> throwCliError $ CustomCliException e | ||
| Left e -> throwCliError e |
| -- TODO This needs to be changed in the future to let the top level exception handler handle the | ||
| -- exceptions printing. | ||
| newExceptT $ | ||
| runRIO () $ |
There was a problem hiding this comment.
Why are we catching here? Why not just: runRIO () $ runAnyCompatibleCommand cmd? toplevelExceptionHandler will handle the exceptions.
|
|
||
| data CompatibleStakeAddressCmds era | ||
| = CompatibleStakeAddressRegistrationCertificateCmd | ||
| (ShelleyBasedEra era) |
There was a problem hiding this comment.
Some haddocks here explaining for instance why we have Maybe Coin would be useful.
|
|
||
| let regCert = makeStakeAddressRegistrationCertificate req | ||
|
|
||
| fromEitherIOCli @_ @(FileError ()) $ |
There was a problem hiding this comment.
Interesting. We are prevented from specifying @(CIO e) because it is a type synonym. However @(RIO e) works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Adds support for more compatible commands
Checklist