Split compatible transaction building and signing

[carbolymer]

Changelog

- description: |
    Split compatible transaction building into separate building and signing functions.
    Rename `Cardano.Api.Internal.Tx.Compatible` to `Cardano.Api.Internal.Compatible.Tx`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

createCompatibleSignedTx wasn't really signing the transaction but just blindly adding signatures. It's split into two separate functions for building and signing.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

I'm not sure what's the best approach here to naming and the argument for the version of this function working on ledger's tx body, so I went with this.

[Jimbo4350]

I would suggest changing the directory name space from: Cardano.Api.Internal.Tx.Compatible to Cardano.Api.Internal.Compatible.Tx. Then you can create Cardano.Api.Internal.Compatible.Witness and add the witness related functions there.

[carbolymer]

I've created Cardano.Api.Internal.Compatible.Tx, but no Cardano.Api.Internal.Compatible.Witness. It would require copying almost half of the cardano-api/src/Cardano/Api/Internal/Tx/Sign.hs into the new compatible module, which I think is not what we want. I think we need to figure out how to isolate this function, but I don't have any idea how to do it elegantly yet.

I'm leaving this out of scope of this PR.

[Jimbo4350]

LGTM 👍. One suggestion.

[Jimbo4350]

I would suggest changing the directory name space from: Cardano.Api.Internal.Tx.Compatible to Cardano.Api.Internal.Compatible.Tx. Then you can add Cardano.Api.Internal.Compatible.Witness.

[Jimbo4350]

I would suggest changing the directory name space from: Cardano.Api.Internal.Tx.Compatible to Cardano.Api.Internal.Compatible.Tx. Then you can create Cardano.Api.Internal.Compatible.Witness and add the witness related functions there.