Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update argument unused on download._download_store_file #230

Open
tgrandje opened this issue Jan 17, 2025 · 1 comment
Open

Update argument unused on download._download_store_file #230

tgrandje opened this issue Jan 17, 2025 · 1 comment

Comments

@tgrandje
Copy link
Collaborator

update argument is ignored by _download_store_file function.

pynsee/pynsee/download/_download_store_file.py

Line 14 in 9dc111f

tempdir: tempfile.TemporaryDirectory, id: str, update: bool

We should check if this is the expected behaviour (I doubt it).
@hadrilec
Copy link
Contributor

indeed this argument is useless and should be removed. This function is only called by download_file which uses the save_df decorator with the argument update

This was referenced Jan 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgrandje @hadrilec