Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Create pipeline tests #53

Closed
5 tasks
bclenet opened this issue Jul 20, 2023 · 3 comments
Closed
5 tasks

[TEST] Create pipeline tests #53

bclenet opened this issue Jul 20, 2023 · 3 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix ☝️ good first issue Good for newcomers 🏁 status: ready for dev Ready for work

Comments

@bclenet
Copy link
Collaborator

bclenet commented Jul 20, 2023

Goal

Create missing tests for pieplines

Why this is useful

Some pipelines don't have associated tests yet. In order to increase code coverage, and make the pipelines compatible with CI workflows, these tests must be created.
Furthermore, the pipeline_tests workflow is currently failing because of these missing files.

Timeline

No response

More specifically

Create one test file per pipeline, i.e.: tests/pipelines/test_team_<team_id>.py, replacing <team_id> by the actual team id.
Feel free to follow already existing pipeline test files as examples. Also, the documentation will help : docs/testing.md docs/pipelines.md 🙂

This applies to the following teams :

  • 43FJ
  • V55J
  • 0I4U
  • 4TQ6
  • 1KB2

Open questions

No response

@bclenet bclenet added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ☝️ good first issue Good for newcomers 🏁 status: ready for dev Ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 20, 2023
@Remi-Gau
Copy link
Contributor

Remi-Gau commented Jul 20, 2023

I could try to add some for the stuff I worked on (4TQ6 R9K3)

@Remi-Gau
Copy link
Contributor

Quick note: is it required to write tests as methods of classes?

pytest allows to have one function per test.

Also asking because this may be less intimidating for new users.

@bclenet
Copy link
Collaborator Author

bclenet commented Aug 21, 2023

One reason to write classes is that it allows to sort the test functions. But you are right, it is not required by pytest.
I'll update the documentation accordingly. Thanks !

@bclenet bclenet mentioned this issue Aug 29, 2023
8 tasks
@bclenet bclenet closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix ☝️ good first issue Good for newcomers 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

2 participants