Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local validation of a team pipeline #35

Closed
cmaumet opened this issue Jun 13, 2023 · 2 comments · Fixed by #138
Closed

Local validation of a team pipeline #35

cmaumet opened this issue Jun 13, 2023 · 2 comments · Fixed by #138
Labels
🧍 aspect: accessibility Concerns developers' experience with the codebase ⭐ goal: addition Addition of new feature 🏁 status: ready for dev Ready for work

Comments

@cmaumet
Copy link
Contributor

cmaumet commented Jun 13, 2023

Note: This issue is a first version that might be reworked in the future.

Goal

The goal is to implement (and document) how to run the pipeline testing locally so that we can validate that a reproduction (e.g. provided in a PR by an external contributor) is successful. A successful reproduction is a piece of code associated with one of the NARPS team that we can run and for which we re-obtain the same results (i.e. correlation > 0.98) as the one published by the team on NeuroVault.

Why is this useful?

It will be useful to be able to run the validation code locally for two reason:

  1. This can be used to decide whether we can merge a PR while we are waiting to find a solution to have this directly in the CI
  2. This can also be useful for contributors to try and validate their own code

Timeline

We'd like a first version for the start of the OHBM Brainhack 2023 - July 19-21, 2023.

More specifically

Open questions:

@cmaumet cmaumet added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jun 13, 2023
@cmaumet cmaumet changed the title Local testing Local validation of a team pipeline Jun 13, 2023
@bclenet bclenet added 🏁 status: ready for dev Ready for work ⭐ goal: addition Addition of new feature 🧍 aspect: accessibility Concerns developers' experience with the codebase and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jun 29, 2023
@cmaumet
Copy link
Contributor Author

cmaumet commented Jul 20, 2023

I think this comment #46 (comment) by @elodiegermani is related :D

@cmaumet
Copy link
Contributor Author

cmaumet commented Jan 9, 2024

Discussed with @bclenet on Jan 9, this is documented in testing.md. Creating a new function/module pipeline.get_correlation that can be run once the pipeline has been implemented to see what the correlation values are.

@bclenet bclenet mentioned this issue Jan 10, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧍 aspect: accessibility Concerns developers' experience with the codebase ⭐ goal: addition Addition of new feature 🏁 status: ready for dev Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants