Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creation of a standard template to add a pipeline script #2

Closed
4 of 5 tasks
elodiegermani opened this issue Jun 8, 2022 · 2 comments
Closed
4 of 5 tasks

Creation of a standard template to add a pipeline script #2

elodiegermani opened this issue Jun 8, 2022 · 2 comments
Assignees
Labels
🧍 aspect: accessibility Concerns developers' experience with the codebase 💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature ☝️ good first issue Good for newcomers 🤝 help wanted Extra attention is needed 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for dev Ready for work

Comments

@elodiegermani
Copy link
Collaborator

elodiegermani commented Jun 8, 2022

Main purpose:
Creation of a standard template of the reproduced pipelines with NiPype based on already reproduced pipelines to facilitate contributions.

Steps:

  • Creation of a template file in the src/lib directory
  • Add prefilled functions (similar to those in the reproduced pipelines scripts) that could be used by new contributors
  • Add sufficient information (comments) for contributors to understand what they have to replace/add
  • Modify CONTRIBUTING.md with guidelines on how to use the template
  • Test of the template by someone who knows NiPype
@elodiegermani elodiegermani added 🤝 help wanted Extra attention is needed 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for dev Ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🧍 aspect: accessibility Concerns developers' experience with the codebase 🔒 staff only Restricted to staff members labels Jun 8, 2022
@elodiegermani elodiegermani self-assigned this Jun 8, 2022
@elodiegermani elodiegermani moved this to Todo in open_pipeline Jun 8, 2022
@elodiegermani elodiegermani added ☝️ good first issue Good for newcomers and removed 🔒 staff only Restricted to staff members labels Jun 8, 2022
elodiegermani added a commit that referenced this issue Jun 17, 2022
elodiegermani added a commit that referenced this issue Jun 17, 2022
bclenet referenced this issue in bclenet/narps_open_pipelines Feb 22, 2023
@elodiegermani
Copy link
Collaborator Author

@bclenet I used the FSL template (https://github.com/Inria-Empenn/narps_open_pipelines/blob/main/narps_open/pipelines/templates/template_fsl.py) to reproduce a pipeline. There is a mistake line 36: # [INFO] There was no run level analysis for the pipelines using FSL -> it's the opposite. In FSL, there is a run-level analysis and then a subject-level one where you merge all runs :)

@bclenet
Copy link
Collaborator

bclenet commented Jul 21, 2023

Thanks @elodiegermani, it looks like my theoretical knowledge of FSL pipelines is wrong 😅
Were you able to find other problems with that file or is it just that ? In other words : should I create a new issue for debugging the template ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧍 aspect: accessibility Concerns developers' experience with the codebase 💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature ☝️ good first issue Good for newcomers 🤝 help wanted Extra attention is needed 🟧 priority: high Stalls work on the project or its dependents 🏁 status: ready for dev Ready for work
Projects
None yet
Development

No branches or pull requests

2 participants